-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security] Make ChainUserProvider::loadUserByIdentifier()
to pass all arguments to its providers
#58773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasiolpn
wants to merge
5
commits into
symfony:7.4
Choose a base branch
from
jasiolpn:chain-user-provider-varargs
base: 7.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a test case?
Hey, I added test case |
xabbuh
reviewed
Nov 6, 2024
src/Symfony/Component/Security/Core/Tests/User/ChainUserProviderTest.php
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Nov 6, 2024
src/Symfony/Component/Security/Core/Tests/User/ChainUserProviderTest.php
Outdated
Show resolved
Hide resolved
ChainUserProvider::loadUserByIdentifier()
to pass all arguments to its providers
I would merge this as a bugfix on 6.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainUserProvider
exists in Symfony since forever, but there is a relatively new feature in Security Component -AttributesBasedUserProviderInterface
which allows to pass custom array from authenticator to the user provider. Unfortunately it does not work if the instance of class that implementsAttributesBasedUserProviderInterface
is "hidden" behindChainUserProvider
. The methodChainUserProvider::loadUserByIdentifier
passes always only its first argument to the chained provider and therefore we loose features intorduced by theAttributesBasedUserProviderInterface
.My solution to this problem assumes that we treat
ChainUserProvider
as a "proxy class" to the internal providers, so we should pass all arguments passed toChainUserProvider::loadUserByIdentifier
to the<internal_provider>::loadUserByIdentifier
.