Skip to content

[Security] Make ChainUserProvider::loadUserByIdentifier() to pass all arguments to its providers #58773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 7.4
Choose a base branch
from
Open

[Security] Make ChainUserProvider::loadUserByIdentifier() to pass all arguments to its providers #58773

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f82276d
Make ChainUserProvider::loadUserByIdentifier() to pass all arguments …
jasiolpn Nov 5, 2024
be52ee3
Updated CHANGELOG
jasiolpn Nov 5, 2024
6e608f3
Added test case
jasiolpn Nov 6, 2024
6ac38ca
removed files
jasiolpn Nov 6, 2024
64ddeb1
Removed calls to equalTo
jasiolpn Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed calls to equalTo
  • Loading branch information
@jasiolpn
jasiolpn committed Nov 6, 2024
commit 64ddeb1dfbe0212d2c121e43cf5e0f325db7dfd7
4 changes: 2 additions & 2 deletions src/Symfony/Component/Security/Core/Tests/User/ChainUserProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ public function testLoadUserByIdentifierPassesAllArgumentsToInternalProviders():
$provider1
->expects($this->once())
->method('loadUserByIdentifier')
->with($this->equalTo('foo'))
->with('foo')
->willThrowException(new UserNotFoundException('not found'))
;

$provider2 = $this->createMock(AttributesBasedUserProviderInterface::class);
$provider2
->expects($this->once())
->method('loadUserByIdentifier')
->with($this->equalTo('foo'), $this->equalTo(['bar' => 'baz']))
->with('foo', ['bar' => 'baz'])
->willReturn($account = $this->createMock(UserInterface::class))
;

Expand Down