Skip to content

[Security] Update incorrect form authenticator changelog item #59080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

bobvandevijver
Copy link
Contributor

@bobvandevijver bobvandevijver commented Dec 3, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues #
License MIT

Related to #53851, #57378 & #59079. Whether or not this an actual CVE, I believe this should be removed from the changelog anyways as it does not throw a bad request anymore.

If we do keep considering it a new feature, it should probably be changed to reflect the correct exception.

As discussed, now only an update to note the actual exception being thrown.

@carsonbot

This comment was marked as resolved.

@bobvandevijver bobvandevijver changed the title Remove incorrect changelog item [Security] Remove incorrect changelog item Dec 3, 2024
@bobvandevijver bobvandevijver changed the base branch from 7.3 to 7.1 December 3, 2024 09:19
@derrabus derrabus modified the milestones: 7.3, 7.1 Dec 3, 2024
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was reverted in #57378

@carsonbot carsonbot changed the title [Security] Remove incorrect changelog item Remove incorrect changelog item Dec 4, 2024
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on a second thought we should probably change this to mention the BadCredentialsException

@bobvandevijver bobvandevijver changed the title Remove incorrect changelog item Update incorrect form authenticator changelog item Dec 4, 2024
@bobvandevijver
Copy link
Contributor Author

@xabbuh Done!

@xabbuh xabbuh added the Security label Dec 4, 2024
@carsonbot carsonbot changed the title Update incorrect form authenticator changelog item [Security] Update incorrect form authenticator changelog item Dec 4, 2024
@fabpot
Copy link
Member

fabpot commented Dec 6, 2024

Thank you @bobvandevijver.

@fabpot fabpot merged commit d5919dd into symfony:7.1 Dec 6, 2024
9 of 10 checks passed
@bobvandevijver bobvandevijver deleted the fix-release-notes branch December 6, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants