-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Security] Update incorrect form authenticator changelog item #59080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was reverted in #57378
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a second thought we should probably change this to mention the BadCredentialsException
162e5d6
to
38f8ec2
Compare
@xabbuh Done! |
Thank you @bobvandevijver. |
Related to #53851, #57378 & #59079.
Whether or not this an actual CVE, I believe this should be removed from the changelog anyways as it does not throw a bad request anymore.If we do keep considering it a new feature, it should probably be changed to reflect the correct exception.As discussed, now only an update to note the actual exception being thrown.