[Scheduler] Fix optional $count variable in testGetNextRunDates
#59125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "6.4". Cheers! Carsonbot |
859e07a to
88e6b36
Compare
| @@ -108,7 +108,7 @@ public static function provideForToString() | |||
| /** | |||
| * @dataProvider providerGetNextRunDates | |||
| */ | |||
| public function testGetNextRunDates(\DateTimeImmutable $from, TriggerInterface $trigger, array $expected, int $count = 0) | |||
| public function testGetNextRunDates(\DateTimeImmutable $from, TriggerInterface $trigger, array $expected, ?int $count = null) | |||
There was a problem hiding this comment.
we never pass null either indeed:
Suggested change
| public function testGetNextRunDates(\DateTimeImmutable $from, TriggerInterface $trigger, array $expected, ?int $count = null) | |
| public function testGetNextRunDates(\DateTimeImmutable $from, TriggerInterface $trigger, array $expected, int $count) |
and let's remove the ?? count below
$count variable in testGetNextRunDates
|
Thanks Nicolas. Changed made! |
88e6b36 to
d8fa076
Compare
xabbuh
approved these changes
Dec 12, 2024
OskarStark
approved these changes
Dec 12, 2024
fabpot
approved these changes
Dec 14, 2024
|
Good catch, thanks @codedmonkey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a weird side effect of the optional
$countvariable intestGetNextRunDates, because it uses the Null Coalescing Operator it was always expecting 0 iterations if not passing a value from the provider.It doesn't need to be optional because it's always passed from the provider so we could just make it a required variable.