-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] Always display service arguments & deprecate --show-arguments
option for debug:container
#59225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0c415df
to
50ffbae
Compare
So with Symfony 7.3 and 7.4, I would see a deprecation if I don’t use Then in Symfony 8.0, using the That sounds counter-intuitive. |
--show-arguments
for debug:container
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then in Symfony 8.0, using the
--show-arguments
option would show a deprecation message?
I agree that it's not a great DX.
We can add the option --hide-arguments
. In 8.0, change the default behavior but keep both options.
src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
Outdated
Show resolved
Hide resolved
Or we could add Asking to opt-in the behavior we want to be the only possible one, before making it the default one and removing the capacity to opt-in/out is what we usually do I think. |
I would keep things simple here:
|
Indeed, command output is not covered by our BC promise. If someone parses the output, they should opt for |
The |
Not really, the only difference is that we'll always have the arguments. |
Yes that’s what I mean, the output will now have an |
50ffbae
to
c090137
Compare
I updated the code to always show arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to see the code simplified.
src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
Outdated
Show resolved
Hide resolved
Please also add a note in the framework-bundle's CHANGELOG and UPGRADE-7.3 about the deprecation. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
c090137
to
18d47f8
Compare
@Florian-Merle, thank you! Good luck with this PR, looking forward to better DX with |
src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
Outdated
Show resolved
Hide resolved
18d47f8
to
377ec8f
Compare
The PR title doesn't match anymore with what the PR does. |
--show-arguments
for debug:container
commanddebug:container
debug:container
--show-arguments
Option for debug:container
--show-arguments
Option for debug:container
--show-arguments
option for debug:container
…w-arguments` option for `debug:container`
377ec8f
to
2641778
Compare
Thank you @Florian-Merle. |
This PR does the following:
--show-arguments
option when a service name is provided and makes it a no-opThe next step will be to remove
--show-arguments
in8.0
.