[JsonEncoder] Fix encoding of dictionary with integer keys #59308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Dec 27, 2024
xabbuh
reviewed
Dec 28, 2024
fabpot
approved these changes
Jan 17, 2025
|
Thank you @mtarld. |
This was referenced Aug 29, 2025
nicolas-grekas
added a commit
that referenced
this pull request
Sep 1, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [JsonStreamer] Fix decoding iterable lists | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #61559 | License | MIT Because a `list<T>` is a subtype of `array<T>`, an `iterable<T>` cannot be a list. This means that, as said [here](#59308 (comment)): > There is no way to be sure that keys of an iterable are successive (even if they are integers). > And if keys are not successive, the resulting JSON structure is an object and not an array. > According, to the [JSON specification](https://datatracker.ietf.org/doc/html/rfc8259#section-4), object' keys must be strings, and not integers. This imply that it is right now impossible to "yield" items from `[{"itemId": 1, "modificationDate": "2025-10-10"}]` - it can only be yielded from `{"0": {"itemId": 1, "modificationDate": "2025-10-10"}}`. I think that in the real world, a lot of people want to be able to yield items from `[...]`, even though it does not stick with the JSON specification. This PR is doing the trade-off of considering `iterable<int, Anything>` as an "iterable list" (like `list<Anything>` but not cast to array). Commits ------- 2b9b801 [JsonStreamer] Fix decoding iterable lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix encoding of dictionary with integer keys.
Previously,
[1 => true, 2 => false]was encoded to{"": true, "": false}, now it is encoded to{"1": true, "2": false}.Also improve test coverage about list, dictionaries and iterable.