Skip to content

[HttpClient] pass CURLOPT_INFILESIZE_LARGE only when supported #59695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025
Merged

[HttpClient] pass CURLOPT_INFILESIZE_LARGE only when supported #59695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Component/HttpClient/CurlHttpClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,8 @@ public function request(string $method, string $url, array $options = []): Respo
}

foreach ($curlopts as $opt => $value) {
if (\CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) {
$opt = 115; // 115 === CURLOPT_INFILESIZE_LARGE, but it's not defined in PHP
if (\PHP_INT_SIZE === 8 && \defined('CURLOPT_INFILESIZE_LARGE') && \CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But before the assignment also happened when the constant is not defined, right? Now it need to be defined 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cURL extension doesn't support option it doesn't know: https://github.com/php/php-src/blob/790286ab6c8954193bbbca778749550a51aceb97/ext/curl/interface.c#L2358

$opt = \CURLOPT_INFILESIZE_LARGE;
}
if (null !== $value && !curl_setopt($ch, $opt, $value) && \CURLOPT_CERTINFO !== $opt && (!\defined('CURLOPT_HEADEROPT') || \CURLOPT_HEADEROPT !== $opt)) {
$constantName = $this->findConstantName($opt);
Expand Down
Loading