Skip to content

[Cache] Tests for Redis Replication with cache #59751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

[Cache] Tests for Redis Replication with cache #59751

merged 1 commit into from
Feb 11, 2025

Conversation

DemigodCode
Copy link
Contributor

@DemigodCode DemigodCode commented Feb 11, 2025 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #49238
License MIT

Adding Replication of Redis to test config and fix bug

@carsonbot carsonbot added this to the 7.2 milestone Feb 11, 2025
@DemigodCode DemigodCode mentioned this pull request Feb 11, 2025
Closed
@carsonbot carsonbot changed the title Tests for Redis Replication with cache [Cache] Tests for Redis Replication with cache Feb 11, 2025
nicolas-grekas
nicolas-grekas approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!
Here is a minor suggestion.
This should target branch 6.4.

@nicolas-grekas nicolas-grekas modified the milestones: 7.2, 6.4 Feb 11, 2025
@DemigodCode DemigodCode changed the base branch from 7.2 to 6.4 February 11, 2025 16:18
@DemigodCode DemigodCode changed the base branch from 6.4 to 7.2 February 11, 2025 16:18
@DemigodCode
Copy link
Contributor Author

DemigodCode commented Feb 11, 2025 •
edited
Loading

Okay, I've tried to change the base branch, but that seems not to be the change you wanted me to do? :)
Do you want me to do the same in the 6.4 branch and create a new PR?

@nicolas-grekas nicolas-grekas changed the base branch from 7.2 to 6.4 February 11, 2025 16:29
@nicolas-grekas
Copy link
Member

Thank you @DemigodCode.

@nicolas-grekas nicolas-grekas merged commit d43bac4 into symfony:6.4 Feb 11, 2025
3 of 10 checks passed
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 14, 2025
Closed
@fabpot fabpot mentioned this pull request Feb 26, 2025
Merged
@fabpot fabpot mentioned this pull request Feb 26, 2025
Merged
@BrianMwit BrianMwit mentioned this pull request Mar 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Cache Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@DemigodCode @nicolas-grekas @carsonbot