Skip to content

[GHA] fix integration tests #59777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

@nicolas-grekas
Copy link
Member Author

@DemigodCode would you mind having a look? Looks like #59751 wasn't quite correct after all ;)

@@ -27,6 +27,25 @@ jobs:
fail-fast: false

services:
frankenphp:
Copy link
Member Author

@nicolas-grekas nicolas-grekas Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reordering because apparently frankenphp is slow to start so we'd benefit from booting it first

@@ -83,15 +102,17 @@ jobs:
REDIS_SENTINEL_QUORUM: 1
redis-primary:
image: redis:latest
hostname: redis-primary
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid entry

ports:
- 16382:6379
command: redis-server --slaveof redis-primary 6379
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid entry also

@DemigodCode
Copy link
Contributor

What happened? The hostname worked correctly in my branch, but it's not necessary.

@xabbuh
Copy link
Member

xabbuh commented Feb 14, 2025

@DemigodCode looking at the PR it seems that GitHub skipped the integration job (at least I don't see it neither failing nor succeeding)

@DemigodCode
Copy link
Contributor

Now I see, haven't seen what failed.

I'll look into it, it's maybe missing the "replication"=>"predis" option when connecting

@DemigodCode
Copy link
Contributor

So, still fixing the tests. Working code is not affected cause I'm already using it in production ;-)

May have some questions regarding the docker containers in github actions. Will let you know.

@DemigodCode
Copy link
Contributor

Okay, seems like I've got the redis replica configured.

Removed the RedisTest, because Phpredis doesn't support replication. That makes it easier ;-)
PredisRedis is working now except the TagAware. Don't know why. It writes the value in the cache but has() returns false.
That doesn't really belong to my changes and I have no idea why.
We're using Replication with Predis and TagAware and it's working fine.
I guess some kind of replication lag?
I would remove this test too. To check if Predis Replication works for both versions, the PredisRedisReplicationAdapterTest is enough.

If you are fine with that, I would go on and create a PR?

@nicolas-grekas
Copy link
Member Author

Please do yes! Thanks!

@DemigodCode
Copy link
Contributor

Did it in 7.2 again. Currently porting it to 6.4

@DemigodCode
Copy link
Contributor

#59782

@nicolas-grekas nicolas-grekas deleted the gha-fix branch February 18, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants