-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[GHA] fix integration tests #59777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHA] fix integration tests #59777
Conversation
nicolas-grekas
commented
Feb 14, 2025
Q | A |
---|---|
Branch? | 6.4 |
Bug fix? | no |
New feature? | no |
Deprecations? | no |
Issues | - |
License | MIT |
db56c95
to
28a8631
Compare
28a8631
to
12db715
Compare
@DemigodCode would you mind having a look? Looks like #59751 wasn't quite correct after all ;) |
12db715
to
e041b61
Compare
@@ -27,6 +27,25 @@ jobs: | |||
fail-fast: false | |||
|
|||
services: | |||
frankenphp: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reordering because apparently frankenphp is slow to start so we'd benefit from booting it first
@@ -83,15 +102,17 @@ jobs: | |||
REDIS_SENTINEL_QUORUM: 1 | |||
redis-primary: | |||
image: redis:latest | |||
hostname: redis-primary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid entry
ports: | ||
- 16382:6379 | ||
command: redis-server --slaveof redis-primary 6379 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid entry also
What happened? The hostname worked correctly in my branch, but it's not necessary. |
@DemigodCode looking at the PR it seems that GitHub skipped the integration job (at least I don't see it neither failing nor succeeding) |
Now I see, haven't seen what failed. I'll look into it, it's maybe missing the "replication"=>"predis" option when connecting |
So, still fixing the tests. Working code is not affected cause I'm already using it in production ;-) May have some questions regarding the docker containers in github actions. Will let you know. |
Okay, seems like I've got the redis replica configured. Removed the RedisTest, because Phpredis doesn't support replication. That makes it easier ;-) If you are fine with that, I would go on and create a PR? |
Please do yes! Thanks! |
Did it in 7.2 again. Currently porting it to 6.4 |