[TypeInfo] Add CollectionType::mergeCollectionValueTypes()
#59824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 21, 2025
bdeef1a to
2bf88ad
Compare
2bf88ad to
b990f68
Compare
fabpot
approved these changes
Feb 26, 2025
|
Thank you @mtarld. |
GromNaN
added a commit
that referenced
this pull request
Mar 14, 2025
This PR was merged into the 7.3 branch.
Discussion
----------
[TypeInfo] Add `ArrayShapeType` class
| Q | A
| ------------- | ---
| Branch? | 7.3
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Issues |
| License | MIT
Introduces the `ArrayShapeType` that holds the exact shape of an array. Also enables the `StringTypeResolver` to parse `array{foo: int, bar?: string}` and to create the appropriate type.
This PR needs #59824 to be merged first.
Commits
-------
af1231b [TypeInfo] Add `ArrayShapeType`
symfony-splitter
pushed a commit
to symfony/type-info
that referenced
this pull request
Mar 14, 2025
This PR was merged into the 7.3 branch.
Discussion
----------
[TypeInfo] Add `ArrayShapeType` class
| Q | A
| ------------- | ---
| Branch? | 7.3
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Issues |
| License | MIT
Introduces the `ArrayShapeType` that holds the exact shape of an array. Also enables the `StringTypeResolver` to parse `array{foo: int, bar?: string}` and to create the appropriate type.
This PR needs symfony/symfony#59824 to be merged first.
Commits
-------
af1231b0dd [TypeInfo] Add `ArrayShapeType`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, when calling the following code:
used to throw an exception saying:
Cannot create union with both "object" and class type.. This PR fixes that, allowing the method to return the properType::list(Type::object()).It also creates the
CollectionType::mergeCollectionValueTypes()method to encapsulate this logic (as it'll be used in future PRs).