[Console] Mark AsCommand attribute as @final
#60103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Apr 1, 2025
derrabus
approved these changes
Apr 1, 2025
mtarld
approved these changes
Apr 1, 2025
GromNaN
approved these changes
Apr 1, 2025
OskarStark
approved these changes
Apr 1, 2025
|
Thank you @Somrlik. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsCommandattribute doesn't work as expected when extended and probably should be declared as final.In order to not break BC and trigger a deprecation warning, I marked the attribute as
@finalas per suggestions in previous PR.Superseeds #60066 as I closed it accidentally, sorry for confusion 😕