Skip to content

[DoctrineBridge] Improve exception message when EntityValueResolver gets no mapping information #60112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

[DoctrineBridge] Improve exception message when EntityValueResolver gets no mapping information #60112

merged 1 commit into from
Apr 2, 2025

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #60111
License MIT

Message based on

symfony/src/Symfony/Bridge/Doctrine/ArgumentResolver/EntityValueResolver.php

Line 188 in 1a8b82e

trigger_deprecation('symfony/doctrine-bridge', '7.1', 'Relying on auto-mapping for Doctrine entities is deprecated for argument $%s of "%s": declare the identifier using either the #[MapEntity] attribute or mapped route parameters.', $argument->getName(), method_exists($argument, 'getControllerName') ? $argument->getControllerName() : 'n/a');

@carsonbot carsonbot added this to the 7.3 milestone Apr 1, 2025
@MatTheCat MatTheCat force-pushed the ticket_60111 branch 2 times, most recently from 5d37049 to 094ae03 Compare April 2, 2025 07:53
MatTheCat
MatTheCat commented Apr 2, 2025
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Apr 2, 2025

Thank you @MatTheCat.

@fabpot fabpot merged commit 110762f into symfony:7.3 Apr 2, 2025
10 of 11 checks passed
@MatTheCat MatTheCat deleted the ticket_60111 branch April 2, 2025 14:59
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
DoctrineBridge Feature Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

Make failed entity argument resolving display a usefull error message
4 participants
@MatTheCat @fabpot @nicolas-grekas @carsonbot