[Emoji] Update the list of emojis to the latest version for Gitlab #60190
+7,732
−1,745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
commented
Apr 10, 2025
| @@ -4,7 +4,7 @@ | |||
| update: ## Update sources | |||
| @composer update | |||
| @curl https://api.github.com/emojis > vendor/github-emojis.json | |||
| @curl https://gitlab.com/gitlab-org/gitlab/-/raw/master/fixtures/emojis/index.json > vendor/gitlab-emojis.json | |||
| @curl https://gitlab.com/gitlab-org/gitlab/-/raw/master/fixtures/emojis/digests.json > vendor/gitlab-emojis.json | |||
There was a problem hiding this comment.
Comment on lines
-157
to
-159
| foreach ($emojiItem['aliases'] as $alias) { | ||
| $maps[$emojiPriority][$alias] = $emoji; | ||
| } |
There was a problem hiding this comment.
Aliases were always empty anyway
stof
approved these changes
Apr 10, 2025
|
I updated the PR title to have a better changelog entry (to me, this deserves being mentioned in the changelog) |
alexandre-daubois
approved these changes
Apr 11, 2025
|
fabbot suggests adding a license header to the scripts, which seems correct. |
We didn't do that on other files. Should I open another PR to fix all other files? |
GromNaN
approved these changes
Apr 11, 2025
fabbot does not complain anymore :) |
|
Thank you @lyrixx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the internal tooling used to perform the update.