Skip to content

Review Tagalog translations for security and validator components #60230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

edmer664
Copy link
Contributor

@edmer664 edmer664 commented Apr 17, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #51902
License MIT

I'm a tagalog native speaker and this pull request addresses issue #51902 by adding the missing Tagalog (tl) translations for the following components:

  • security.tl.xlf
  • validators.tl.xlf

Key Changes:

  1. Updated translations in security.tl.xlf:

    • Ensured translations adhere to the tone and style of existing translations.
  2. Updated translations in validators.tl.xlf:

    • Reviewed and updated translations for consistency and accuracy.

Why this is important:

These changes enhance Symfony's localization support, ensuring a better experience for Tagalog-speaking users.

@edmer664 edmer664 requested a review from chalasr as a code owner April 17, 2025 07:51
@carsonbot carsonbot added this to the 6.4 milestone Apr 17, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@edmer664 edmer664 changed the title Add Tagalog translations for security and validator components Review Tagalog translations for security and validator components Apr 17, 2025
@fabpot
Copy link
Member

fabpot commented Apr 17, 2025

Thank you @edmer664.

@fabpot fabpot merged commit c72a7c4 into symfony:6.4 Apr 17, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants