Skip to content

[Lock] read (possible) error from Redis instance where evalSha() was called #60238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 17, 2025

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh
Copy link
Member Author

xabbuh commented Apr 17, 2025

I stumbled upon this issue while working on #58370. It took me a while to find the root cause as the CI currently isn't failing despite the bug that's being fixed in this PR (probably because the order in which tests are executed matters). That's why I split the PR into three commits (we can still squash them while merging though):

  1. reduce the CI config for the Windows job to showcase that the tests actually fail without the fix
  2. the fix being applied with restoring the original config to show that the patch does indeed fix the issue
  3. restoring the CI config to the previous state

@chalasr
Copy link
Member

chalasr commented Apr 17, 2025

Good catch, thanks @xabbuh.

@chalasr chalasr merged commit c95fe4a into symfony:7.2 Apr 17, 2025
7 of 11 checks passed
@xabbuh xabbuh deleted the pr-59488 branch April 17, 2025 22:03
@fabpot fabpot mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants