[HttpClient] Improve memory consumption #60241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @nicolas-grekas 👋🏻 |
44a5e56 to
7212515
Compare
|
It's related yes: the same approach could be taken for all traceable decorators. Help wanted for the others /cc @lyrixx et al. |
08fe94b to
d2bcf96
Compare
stof
reviewed
Apr 18, 2025
6a518ff to
b102057
Compare
nicolas-grekas
commented
Apr 18, 2025
| ) { | ||
| $this->tracedRequests = new \ArrayObject(); | ||
| } | ||
|
|
||
| public function enabled(?bool $enabled = null): bool |
There was a problem hiding this comment.
(the class is final already)
stof
reviewed
Apr 18, 2025
src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php
Outdated
Show resolved
Hide resolved
b102057 to
0e865e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the CLI, even if the profiler is not enabled by default, the underlying infrastructure is still in place.
In this PR, I'm targeting TraceableHttpClient, which collects requests and responses for nothing.
To fix this, I'm adding an "enabled" flag on TraceableHttpClient, so that we can enable the tracing only when the profiler is enabled.
In addition, I'm augmenting option
extra.trace_contentso that when disabled, we don't collect request's bodies, which can be huge when uploading.And last but not least, I'm fixing the implementation of curl's debug info collection, which currently relies on allocating new strings all the time instead of reusing the already created zval when debug info didn't change.