[Translation] drop support for nikic/php-parser 4 #60255
Merged
+2
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Apr 23, 2025
|
Thank you @xabbuh. |
|
A conflict rule probably needs to be added (the |
|
btw, this does not clean the code related to the php-parser v4 (it only makes it untested) |
If I am not mistaken, we don't have v4-specific code since #53475. |
|
ah indeed. I forgot that PR. |
chalasr
added a commit
that referenced
this pull request
Apr 24, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Translation] conflict with nikic/php-parser 4 | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | see #60255 (comment) | License | MIT Commits ------- 9cb5585 conflict with nikic/php-parser 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #58370, background: PHPUnit 11 is no longer compatible with
nikic/php-parser4 (see #58370 (comment)).