-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Contracts] Fix ServiceMethodsSubscriberTrait
for nullable service
#60267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fabpot
merged 1 commit into
symfony:7.2
from
StevenRenaux:fix/Fix-nullable-argument-for-SubscribedService-attribute
Apr 30, 2025
Merged
[Contracts] Fix ServiceMethodsSubscriberTrait
for nullable service
#60267
fabpot
merged 1 commit into
symfony:7.2
from
StevenRenaux:fix/Fix-nullable-argument-for-SubscribedService-attribute
Apr 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a9c3a2
to
7d7e4a0
Compare
db4b606
to
562600f
Compare
562600f
to
e67db9a
Compare
#60268 should be merged first and upmerged to 7.2, so that this PR can then be only about the new things for 7.2 |
ServiceMethodsSubscriberTrait
for nullable serviceServiceMethodsSubscriberTrait
for nullable service
@StevenRenaux I'm not saying this PR is useless. This PR should be updated after the upmerge (which will happen anyway) |
welcoMattic
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fabpot
approved these changes
Apr 30, 2025
Thank you @StevenRenaux. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in a bundle context.
If you use the following example, you will get an exception:
ServiceNotFoundException: The service "twig" in the container provided to "App\Service\Dependency" has a dependency on a non-existent service "Twig\Environment".
The
nullable
argument of theSubscribedService
attribute is ignored.Related to #60265