-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PhpUnitBridge] Add strtotime()
to ClockMock
#60424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.3
Are you sure you want to change the base?
[PhpUnitBridge] Add strtotime()
to ClockMock
#60424
Conversation
jprivet-dev
commented
May 15, 2025
•
edited
Loading
edited
Q | A |
---|---|
Branch? | 7.4 |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Issues | |
License | MIT |
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
9130864
to
e391ecb
Compare
e391ecb
to
153464b
Compare
strtotime()
to ClockMock
This won't make it to 7.3 as we are in feature freeze. It will be for 7.4. And this new feature needs to be mentioned in the changelog of the component. |
Thanks @stof for your feedback :)
|