Skip to content

[PhpUnitBridge] Add strtotime() to ClockMock #60424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 7.3
Choose a base branch
from

Conversation

jprivet-dev
Copy link

@jprivet-dev jprivet-dev commented May 15, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [PHPUnitBridge] Add strtotime() to ClockMock [PhpUnitBridge] Add strtotime() to ClockMock May 15, 2025
@jprivet-dev jprivet-dev force-pushed the phpunit-bridge-clockmock-strtotime branch from 9130864 to e391ecb Compare May 15, 2025 07:00
@jprivet-dev jprivet-dev force-pushed the phpunit-bridge-clockmock-strtotime branch from e391ecb to 153464b Compare May 15, 2025 07:05
@OskarStark OskarStark changed the title [PhpUnitBridge] Add strtotime() to ClockMock [PhpUnitBridge] Add strtotime() to ClockMock May 15, 2025
@stof
Copy link
Member

stof commented May 15, 2025

This won't make it to 7.3 as we are in feature freeze. It will be for 7.4.

And this new feature needs to be mentioned in the changelog of the component.

@jprivet-dev
Copy link
Author

jprivet-dev commented May 15, 2025

Thanks @stof for your feedback :)

And this new feature needs to be mentioned in the changelog of the component.

  • Added

This won't make it to 7.3 as we are in feature freeze. It will be for 7.4.

  • I'm waiting for the 7.4 branch to update this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants