[Console] Improve #[Argument]/#[Option] exception messages
#60447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kbond it seems tests failures are related |
|
Ak, indeed, I'll get them fixed |
OskarStark
reviewed
May 18, 2025
GromNaN
reviewed
May 19, 2025
src/Symfony/Component/Console/Tests/Command/InvokableCommandTest.php
Outdated
Show resolved
Hide resolved
|
I opted to remove the exception message assertion rather than dig into crazy regex. If someone has a better method, let me know! |
fabpot
approved these changes
May 24, 2025
38f6561 to
c9d7c63
Compare
|
Thank you @kbond. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the class/method in
#[Argument]/#[Option]exception messages.Example