[Console] Improve #[Argument]/#[Option] exception messages
#60447
+36
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception messages now include the method: > The option parameter "$a" of "App\Command\SendSalesReportsCommand::__invoke()" must declare a default value.
|
@kbond it seems tests failures are related |
|
Ak, indeed, I'll get them fixed |
OskarStark
reviewed
May 18, 2025
GromNaN
reviewed
May 19, 2025
| @@ -27,6 +27,8 @@ | |||
|
|
|||
| class InvokableCommandTest extends TestCase | |||
| { | |||
| private const FUNCTION_NAME = 'Symfony\Component\Console\Tests\Command\InvokableCommandTest::Symfony\Component\Console\Tests\Command\{closure}()'; | |||
There was a problem hiding this comment.
I don't understand the 2 namespaces? It should be Symfony\Component\Console\Tests\Command\InvokableCommandTest\{closure}()
There was a problem hiding this comment.
I copied the code to extract the function name from
. With closures it's a little wonky I admin - plus it changes in 8.4 to include more context (hence the current failures).For invokable classes, which most of these new commands will be in practice, the name looks like you expect: App\Command\SendSalesReportsCommand::__invoke()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the class/method in
#[Argument]/#[Option]exception messages.Example