Skip to content

Conversation

BafS
Copy link
Contributor

@BafS BafS commented May 23, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52486
License MIT

Hello,

It seems to be an old issue (see #52486) but the format sent to Clicksend is not correct. When using the library we have this error: [Symfony\Component\Notifier\Exception\TransportException] Unable to send the SMS - "{"http_code":400,"response_code":"BAD_REQUEST","response_msg":"The messages array is empty.","data":null}". The correct structure should have a "messages" key (see documentation: https://developers-dev.clicksend.net/docs/messaging/sms/other/send-sms).

@BafS BafS requested a review from OskarStark as a code owner May 23, 2025 16:21
@carsonbot carsonbot added this to the 6.4 milestone May 23, 2025
@carsonbot carsonbot changed the title Fix clicksend transport [Notifier] Fix clicksend transport May 23, 2025
@OskarStark
Copy link
Contributor

Can you please add a test case or adjust an existing if already present? Thanks

@OskarStark OskarStark changed the title [Notifier] Fix clicksend transport [Notifier] Fix Clicksend transport May 23, 2025
@BafS
Copy link
Contributor Author

BafS commented May 23, 2025

AmpHttpClientTest error seem unrelated to my change

@fabpot
Copy link
Member

fabpot commented May 23, 2025

Thank you @BafS.

@fabpot fabpot merged commit 6eef5a7 into symfony:6.4 May 23, 2025
11 checks passed
This was referenced May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants