[DependencyInjection][FrameworkBundle] Use php-serialize to dump the container for debug/link commands #60597
+73
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25b4fc6 to
965f23d
Compare
…container for debug/link commands
965f23d to
013e6ce
Compare
chalasr
reviewed
May 30, 2025
GromNaN
reviewed
May 30, 2025
| $container->getCompilerPassConfig()->setBeforeOptimizationPasses([]); | ||
| $container->getCompilerPassConfig()->setOptimizationPasses([]); | ||
| $container->getCompilerPassConfig()->setBeforeRemovingPasses([]); | ||
| if (str_ends_with($file, '.xml') && is_file(substr_replace($file, '.ser', -4))) { |
There was a problem hiding this comment.
The .ser file name extension seems common in Java. It makes sense to use it for serialized data in PHP too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unlock #60568 this uses
serialize()to dump the container, next to the XML dump.