chore: PHP CS Fixer - restore PHP / PHPUnit rulesets #61371
Merged
+109
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
commented
Aug 9, 2025
|
I don't know if we should use |
|
well, Fixer relies here on explicit octal PHP notation |
|
Alright, not a big fan of it, but I'm not strongly against it either |
derrabus
approved these changes
Aug 12, 2025
|
Thank you @keradus. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 13, 2025
This PR was merged into the 7.4 branch. Discussion ---------- chore: PHP CS Fixer - update heredoc handling | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix CS <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Inspired while #61371 , but can be merged separately. ``@PHPxMigration`` and ``@Symfony`` ruleset have different config for those rules. I assume the difference is coming from supporting pre-7.2 PHP version earlier in the codebase, where heredoc closure and trailing comma had to be on separated lines - but it's no longer the case. Can we benefit from newer PHP syntax and incorporate those changes? (yes, `trailing_comma_in_multiline`, part of ``@Symfony``, is already having this enabled!) if so, i will also merge them into ``@Symfony`` ruleset itself afterwards. with love by [PHP Coding Standards Fixer](https://cs.symfony.com/) Commits ------- f995622 chore: PHP CS Fixer - update heredoc handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to 5d4e211#r163638626 , showing:
with love by PHP Coding Standards Fixer