rebase needed

I made some handcrafted tweaks.
BTW, would it be possible to tell php-cs-fixer to stop removing whitespaces at the end of lines inside heredocs?

BTW, would it be possible to tell php-cs-fixer to stop removing whitespaces at the end of lines inside heredocs?

I think we should find a better way than having the need for trailing spaces in some tests as dealing with them is also a mess when you open these test files in your local IDE for doing other changes in that file and your IDE then strips all trailing whitespaces.

I made some handcrafted tweaks.

👍🏻
minor, but on such changes i would also recommend to start very first argument in new line. otherwise, argument 0 starts in line 0 (run-in), but argument 1 start in line 1(-ish) (like listed items)

BTW, would it be possible to tell php-cs-fixer to stop removing whitespaces at the end of lines inside heredocs?

do you have an example of Fixer doing that? I can't see it in this PR, and we tried hard to not remove trailing whitespace inside of string, as it would change the meaning of the code.
( I also enjoy suggestion of @xabbuh , and would love to have it this way as well - yet regardless of that, Fixer should not change string content)

separately, good to merge, I think ?

See Fabbot's report in the CI failures: php-cs-fixer suggests many changes inside heredoc that we don't want.

ok, thanks for hint what you meant.
so it's not about heredoc rules. it's becuase Sf ruleset has no_trailing_whitespace_in_string enabled, whish is RISKY rule exactly of this reason.

to change the behaviour, we simply need to disable that rule for the project, but tbh - i would rather keep it enabled, as for 99% cases, removal of trailing whitespaces is expected, and as @xabbuh mentioned, having them is also fooling other tools like IDE

Ah that's good to know. This should be disabled to me. Strings are strings - aka not up for CS fixes.

that's where we have no_trailing_whitespace for non-string trailing whitespaces ;) [non-risky change].

i recommend to not block this PR due to no_trailing_... rules, and conclude on those trailing whitespaces separately.

from practice, most of cases i had strings i actually wanted to remove such spaces, but happy to go both ways and update the ruleset if concluded (or please, feel free to send such PR as well).

as alternative solution, we can change way we write such strings, eg:

--- a/src/Symfony/Component/Console/Tests/Helper/TableTest.php
+++ b/src/Symfony/Component/Console/Tests/Helper/TableTest.php
@@ -1832,20 +1832,20 @@ class TableTest extends TestCase
         ];
 
         yield 'Borderless style' => [
-            <<<EOTXT
-                 ============================== 
-                    ISBN: 99921-58-10-7         
-                   Title: Divine Comedy         
-                  Author: Dante Alighieri       
-                   Price: 9.95                  
-                 ============================== 
-                    ISBN: 9971-5-0210-0         
-                   Title: A Tale of Two Cities  
-                  Author: Charles Dickens       
-                   Price: 139.25                
-                 ============================== 
-
-                EOTXT,
+            implode("\n", [
+                ' ============================== ',
+                '    ISBN: 99921-58-10-7         ',
+                '   Title: Divine Comedy         ',
+                '  Author: Dante Alighieri       ',
+                '   Price: 9.95                  ',
+                ' ============================== ',
+                '    ISBN: 9971-5-0210-0         ',
+                '   Title: A Tale of Two Cities  ',
+                '  Author: Charles Dickens       ',
+                '   Price: 139.25                ',
+                ' ============================== ',
+                '',
+            ]),

benefit? no other tools (like IDE) will complain on trailing whitespaces.

Thank you @keradus.

@nicolas-grekas , would you like to re-visit no_trailing_whitespace_in_string ? it's recommended directly from PSR / PER-CS

@nicolas-grekas , also as you are on fire, please check PHP-CS-Fixer/PHP-CS-Fixer#8930