Skip to content

[Validator] BC break in Length or Count constraint XML configuration #61613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Validator] BC break in Length or Count constraint XML configuration #61613

wants to merge 1 commit into from

Conversation

ernestwisniewski
Copy link

Q A
Branch? 7.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Tickets -
License MIT

#61612

@carsonbot carsonbot added this to the 7.4 milestone Sep 3, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@ernestwisniewski ernestwisniewski changed the base branch from 7.4 to 7.3 September 3, 2025 12:50
@xabbuh xabbuh mentioned this pull request Sep 3, 2025
Merged
@xabbuh
Copy link
Member

xabbuh commented Sep 3, 2025

I suggest to fix this in a more generic manner in #61617

nicolas-grekas added a commit that referenced this pull request Sep 4, 2025
@nicolas-grekas
bug #61617 [Validator] fall back to legacy options handling if config…
e7c41fe 
…ured named arguments do not match (xabbuh)

This PR was merged into the 7.3 branch.

Discussion
----------

[Validator] fall back to legacy options handling if configured named arguments do not match

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #61612
| License       | MIT

generalized alternative to #61613

Commits
-------

9ddd0d7 fall back to legacy options handling if configured named arguments do not match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Deprecation Status: Needs Review Validator
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ernestwisniewski @carsonbot @xabbuh @nicolas-grekas