[Validator] fall back to legacy options handling if configured named arguments do not match #61617
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
commented
Sep 3, 2025
| @@ -97,7 +97,7 @@ protected function newConstraint(string $name, mixed $options = null): Constrain | |||
| return new $className($options['value']); | |||
| } | |||
|
|
|||
| if (array_is_list($options)) { | |||
| if (array_is_list($options) || isset($options['value'])) { | |||
There was a problem hiding this comment.
This might be a bit risky if the constraint has a constructor argument named $value.
An alternative solution would be wrapping the call further down in a try catch block like this:
try {
return new $className(...$options);
} catch (\Error $e) {
if (str_starts_with($e->getMessage(), 'Unknown named parameter')) {
return new $className($options);
}
throw $e;
}There was a problem hiding this comment.
in any case, we should deprecate this in 7.4 after merging up
There was a problem hiding this comment.
let's do it the safest way?
|
Thank you @xabbuh. |
|
Thanks! Follow up welcome on 7.4 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generalized alternative to #61613