Skip to content

[MessageCatalogue] Add Metadata to MessageCatalogue #6349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 15, 2012

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Dec 14, 2012

rework of #4399

For improving the Gettext tools (PO, MO File Loader/Dumper) we need at least storage for their meta data.

This patch allows for issues below to store and process ie Po Header, Po Header Pluralisation rule.

Open

Closed:

It has 1 TODO regarding addCatalogue: it now just override old values with new.

fabpot added a commit that referenced this pull request Dec 15, 2012
This PR was merged into the master branch.

Commits
-------

320fb6c [Translation] changed the MetadataAwareInterface method signatures
11ff433 [Translation] fixed CS in unit tests
c40db35 [Translation] removed some code that is not done anywhere else in Symfony
63719a0 [Translation] created a new interface to avoid breaking BC
23e9e65 [Translation] fixed name
5607732 [Translation] added Metadata to MessageCatalogue

Discussion
----------

[MessageCatalogue] Add Metadata to MessageCatalogue

rework of #4399

For improving the Gettext tools (PO, MO File Loader/Dumper) we need at least storage for their meta data.

This patch allows for issues below to store and process ie Po Header, Po Header Pluralisation rule.

Open
- [[WIP]: Allow Drupal to use Translate component](#4249)
- [[2.1][Translator] Symfony translation process & gettext](#4245)

Closed:
- [[Translation] Po/MoFileLoader parse plurization rules](#3023)

It has 1 TODO regarding addCatalogue: it now just override old values with new.
@fabpot fabpot closed this Dec 15, 2012
@fabpot fabpot merged commit 320fb6c into symfony:master Dec 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants