-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[DIC] Move PrependExtensionInterface to the Extension namespace #6853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vicb please update the doc too |
@stof good catch thanks, I'll update tomorrow. |
That looks wrong to me and that's not what we've done with other specialized interfaces that we added in the past for other components. |
you are right |
I think the question simply is whether there is a reason to implement On Thu, Jan 24, 2013 at 9:03 AM, Victor Berchet notifications@github.comwrote:
|
I agree. |
@lsmith77 @fabpot @stof One more question: does prepend really solve anything ? What if multiple bundles prepend ? A solution could be to have some kind of priorities, what do you think ? @schmittjoh sometimes you have |
@vicb we discussed this in the PR .. the assumption is that there will be very few prepending extensions. more importantly these will be mostly applications. in the original implementation it was required for the user to explicitly enable the behavior which would make it possible to prevent conflicts. |
I also find the name unfortunate as we do not prepend an extension but some settings |
@fabpot Please merge before 2.2 (no BC break) /cc @lsmith77