Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 23, 2013

@fabpot Please merge before 2.2 (no BC break) /cc @lsmith77

fabpot added a commit that referenced this pull request Jan 23, 2013
This PR was merged into the master branch.

Commits
-------

7944860 [DIC] Move PrependExtensionInterface to the Extension namespace

Discussion
----------

[DIC] Move PrependExtensionInterface to the Extension namespace

@fabpot Please merge before 2.2 (no BC break) /cc @lsmith77
@fabpot fabpot merged commit 7944860 into symfony:master Jan 23, 2013
@stof
Copy link
Member

stof commented Jan 23, 2013

@vicb please update the doc too

@vicb vicb deleted the di/prepext branch January 23, 2013 20:05
@vicb
Copy link
Contributor Author

vicb commented Jan 23, 2013

@stof good catch thanks, I'll update tomorrow.

@vicb
Copy link
Contributor Author

vicb commented Jan 24, 2013

@stof @lsmith77 @fabpot what about having PrependExtensionInterface extends ExtensionInterface to avoid having to implements ExtensionInterface, PrependExtensionInterface ?

@fabpot
Copy link
Member

fabpot commented Jan 24, 2013

That looks wrong to me and that's not what we've done with other specialized interfaces that we added in the past for other components.

@vicb
Copy link
Contributor Author

vicb commented Jan 24, 2013

you are right

@schmittjoh
Copy link
Contributor

I think the question simply is whether there is a reason to implement
PrependExtensionInterface without ExtensionInterface. If you always have to
implement the latter when using the former, then you can as well extend it
directly, no?

On Thu, Jan 24, 2013 at 9:03 AM, Victor Berchet notifications@github.comwrote:

you are right


Reply to this email directly or view it on GitHubhttps://github.com//pull/6853#issuecomment-12641197.

@Tobion
Copy link
Contributor

Tobion commented Jan 24, 2013

I agree.

@vicb
Copy link
Contributor Author

vicb commented Jan 24, 2013

@lsmith77 @fabpot @stof One more question: does prepend really solve anything ? What if multiple bundles prepend ? A solution could be to have some kind of priorities, what do you think ?

@schmittjoh sometimes you have MyExt extends Extension implements PrependExtensionInterface having PrependExtensionInterface extends ExtensionInterface would look messy.

@lsmith77
Copy link
Contributor

@vicb we discussed this in the PR .. the assumption is that there will be very few prepending extensions. more importantly these will be mostly applications. in the original implementation it was required for the user to explicitly enable the behavior which would make it possible to prevent conflicts.

@vicb
Copy link
Contributor Author

vicb commented Jan 24, 2013

I also find the name unfortunate as we do not prepend an extension but some settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants