[OptionsResolver] added ability to allow extra options #7985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kbond
commented
May 9, 2013
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7979 |
| License | MIT |
| Doc PR | todo |
| @@ -54,6 +54,12 @@ class OptionsResolver implements OptionsResolverInterface | |||
| private $allowedTypes = array(); | |||
|
|
|||
| /** | |||
| * Whether to allow extra options | |||
| * @var bool | |||
There was a problem hiding this comment.
in Symfony codebase/standard it's Boolean
|
This should get documented in components/options_reaolver |
|
I will document it, I just wanted to see if this feature will be merged before I do. |
|
👍 |
1 similar comment
|
👍 |
|
ping @fabpot should we create the documentation ticket for hacking day or before? would be good to know if this will be merged at least |
|
when is the hack day? at SymfonyCon? |
|
yeah online and in person options --> http://doodle.com/vycrabazihq926yq |
|
@cordoval I prefer a PR and if not, just add an issue. |
|
Closing in favor of #9754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.