[Process] Fixed #8455: PhpExecutableFinder::find() does not always return the correct binary #8456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways return the correct binary
fabpot
added a commit
that referenced
this pull request
Jul 21, 2013
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #8456). Discussion ---------- [Process] Fixed #8455: PhpExecutableFinder::find() does not always return the correct binary Since `PHP_BINARY` is the very first approach considered, there is no way to use a workaround like setting the `PHP_PATH`. Checking `PHP_PATH` could potentially be put before checking `PHP_BINARY`: that would avoid an extra function call (and system call), at the price of a small BC_BREAK, but I think it's better in this case to have a solution that doesn't force people to set the `PHP_PATH` environment variable. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8455 | License | MIT | Doc PR | none Commits ------- 35a2fe4 [Process] Fixed #8455: PhpExecutableFinder::find() does not always return the correct binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
PHP_BINARYis the very first approach considered, there is no way to use a workaround like setting thePHP_PATH.Checking
PHP_PATHcould potentially be put before checkingPHP_BINARY: that would avoid an extra function call (and system call), at the price of a small BC_BREAK, but I think it's better in this case to have a solution that doesn't force people to set thePHP_PATHenvironment variable.