Skip to content

Overwrite exist method of Twig FilesystemLoader (2.2) #8672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Overwrite exist method of Twig FilesystemLoader (2.2) #8672

wants to merge 1 commit into from

Conversation

hacfi
Copy link
Contributor

@hacfi hacfi commented Aug 5, 2013

  • Implement exist method for the Symfony\Bundle\TwigBundle\Loader\FilesystemLoader to allow bundle syntax for templates
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets fabpot/Twig#1156, #8665
License MIT

The issue with The profiler template "SecurityBundle:Collector:security.html.twig" for data collector "security" does not exist. also happens in 2.2 so I’m creating this new PR against 2.2.

- Implement exist method for the Symfony\Bundle\TwigBundle\Loader\FilesystemLoader to allow bundle syntax for templates
public function exists($name)
{
// for BC
if ($this->doFindTemplate($name)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that does not work as this method does not exist in all versions of Twig.

@hacfi
Copy link
Contributor Author

hacfi commented Aug 5, 2013

Alright..I just tried fixing the code which I had installed.

Closing as fabpot/Twig@d2b97b4 has been reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants