[Process] Renamed flushOutput() and flushErrorOutput() to clearOutput() and clearErrorOutput() #9407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() and clearErrorOutput()
|
Same throught when reading the blog post, so 👍 |
|
Nice one @bschussek! Thank you :) |
|
+1 |
|
Discussed exactly that in the origin PR with fabpot |
|
I was confused by this PR until I realised that I misread the blog example. I thought Both PHP and fabpot's usage of the word is correct, to flush is to send something down a path, typically to cleanse. So with that ambiguity and PHP precedence, wouldn't it be more concise to go with |
5 tasks
|
ping @fabpot |
fabpot
added a commit
that referenced
this pull request
Nov 9, 2013
… clearOutput() and clearErrorOutput() (bschussek) This PR was merged into the master branch. Discussion ---------- [Process] Renamed flushOutput() and flushErrorOutput() to clearOutput() and clearErrorOutput() | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I renamed `flushOutput()` and `flushErrorOutput()` to `clearOutput()` and `clearErrorOutput()` since I find the current naming unintuitive. When reading [the blog post about this feature](http://symfony.com/blog/new-in-symfony-2-4-flushing-stdout-and-stderr-on-a-process) I initially thought that the output would be flushed to the console (as in `ob_flush()`). Using "clear" on the other hand conforms well with [our conventions](http://symfony.com/doc/current/contributing/code/conventions.html). Commits ------- 1811367 [Process] Renamed flushOutput() and flushErrorOutput() to clearOutput() and clearErrorOutput()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed
flushOutput()andflushErrorOutput()toclearOutput()andclearErrorOutput()since I find the current naming unintuitive. When reading the blog post about this feature I initially thought that the output would be flushed to the console (as inob_flush()).Using "clear" on the other hand conforms well with our conventions.