minor #8339 [DI] fix flash message generation (xabbuh, javiereguiluz)

javiereguiluz · javiereguiluz · commit df427a76f0ce · 2018-01-04T13:30:07.000+01:00
This PR was merged into the 3.3 branch. Discussion ---------- [DI] fix flash message generation see #8224 (comment) Commits ------- cba0478 Refactored the code cdcb5c8 fix flash message generation
diff --git a/service_container.rst b/service_container.rst
@@ -370,9 +370,8 @@ made. To do that, you create a new class::
                 ->addPart(
                     'Someone just updated the site. We told them: '.$happyMessage
                 );
-            $this->mailer->send($message);
-
-            return $happyMessage;
+            
+            return $this->mailer->send($message) > 0;
         }
     }
 
@@ -386,8 +385,10 @@ you can use the service immediately::
     {
         // ...
 
-        $message = $siteUpdateManager->notifyOfSiteUpdate();
-        $this->addFlash('success', $message);
+        if ($siteUpdateManager->notifyOfSiteUpdate()) {
+            $this->addFlash('success', 'Notification mail was sent successfully.');
+        }
+        
         // ...
     }
 

Original file line number	Diff line number	Diff line change
`@@ -370,9 +370,8 @@ made. To do that, you create a new class::`
`370`	`370`	`->addPart(`
`371`	`371`	`'Someone just updated the site. We told them: '.$happyMessage`
`372`	`372`	`);`
`373`		`- $this->mailer->send($message);`
`374`		`-`
`375`		`- return $happyMessage;`
	`373`	`+`
	`374`	`+ return $this->mailer->send($message) > 0;`
`376`	`375`	`}`
`377`	`376`	`}`
`378`	`377`
`@@ -386,8 +385,10 @@ you can use the service immediately::`
`386`	`385`	`{`
`387`	`386`	`// ...`
`388`	`387`
`389`		`- $message = $siteUpdateManager->notifyOfSiteUpdate();`
`390`		`- $this->addFlash('success', $message);`
	`388`	`+ if ($siteUpdateManager->notifyOfSiteUpdate()) {`
	`389`	`+ $this->addFlash('success', 'Notification mail was sent successfully.');`
	`390`	`+ }`
	`391`	`+`
`391`	`392`	`// ...`
`392`	`393`	`}`
`393`	`394`