SiteUpdateManager should return $happyMessage and not the mailer service #8224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 27, 2017
HeahDude
reviewed
Jul 29, 2017
| @@ -361,7 +361,7 @@ made. To do that, you create a new class:: | |||
| ); | |||
| $this->mailer->send($message); | |||
|
|
|||
| return $message; | |||
| return $happyMessage; | |||
There was a problem hiding this comment.
Not sure this method should return anything. The controller should use a custom alert instead of this returned value.
There was a problem hiding this comment.
I agree with you that this is not an ideal example. I have merged this PR nonetheless as it would make the code at least work as it was supposed to be initially. We should handle the rest in a follow up PR.
|
Thank you @revollat. |
xabbuh
added a commit
that referenced
this pull request
Sep 3, 2017
… mailer service (revollat) This PR was merged into the 3.3 branch. Discussion ---------- SiteUpdateManager should return $happyMessage and not the mailer service Commits ------- e42435c SiteUpdateManager should return $happyMessage and not the mailer service
javiereguiluz
added a commit
that referenced
this pull request
Jan 4, 2018
This PR was merged into the 3.3 branch. Discussion ---------- [DI] fix flash message generation see #8224 (comment) Commits ------- cba0478 Refactored the code cdcb5c8 fix flash message generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.