[DI] fix flash message generation #8339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Sep 3, 2017
service_container.rst
Outdated
| @@ -366,8 +366,6 @@ made. To do that, you create a new class:: | |||
| 'Someone just updated the site. We told them: '.$happyMessage | |||
| ); | |||
| $this->mailer->send($message); | |||
There was a problem hiding this comment.
What about returning return $this->mailer->send($message) > 0; and only adding a success flash message if it was indeed succesfull ?
javiereguiluz
added a commit
that referenced
this pull request
Jan 4, 2018
This PR was merged into the 3.3 branch. Discussion ---------- [DI] fix flash message generation see #8224 (comment) Commits ------- cba0478 Refactored the code cdcb5c8 fix flash message generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #8224 (comment)