Skip to content

[DI] allow loading and dumping tags with an attribute named "name" #13613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue May 3, 2020 · 3 comments · Fixed by #18802
Closed

[DI] allow loading and dumping tags with an attribute named "name" #13613

fabpot opened this issue May 3, 2020 · 3 comments · Fixed by #18802
Labels
DependencyInjection hasPR A Pull Request has already been submitted for this issue. Keep open
Milestone
5.1

Comments

@fabpot
Copy link
Member

fabpot commented May 3, 2020

Q A
Feature PR symfony/symfony#36586
PR author(s) @nicolas-grekas
Merged in 5.1-dev
@xabbuh xabbuh added this to the 5.1 milestone May 4, 2020
@javiereguiluz
Copy link
Member

I don't think we need to document this (and I don't know where(how we could do that). As stated in the original code PR, this is "a minor feature added for consistency".

@stof
Copy link
Member

stof commented Apr 21, 2023

This actually needs to be documented somewhere in https://symfony.com/doc/current/service_container/tags.html#adding-additional-attributes-on-tags to show how to do the XML configuration for such case (especially given that some core tags rely on the name attribute)

@OskarStark OskarStark reopened this Apr 21, 2023
@stof stof mentioned this issue Apr 21, 2023
Closed
@alexandre-daubois alexandre-daubois mentioned this issue Aug 30, 2023
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this issue Aug 31, 2023
@javiereguiluz
minor symfony#18802 [DependencyInjection] Allow loading and dumping t…
8683ab5 
…ags with an attribute named "name" (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[DependencyInjection] Allow loading and dumping tags with an attribute named "name"

Not an easy one to fully understand. Friendly ping `@stof` as you participated to the issue 🙂 Thanks!

Fix symfony#13613

Commits
-------

52aee81 [DependencyInjection] Allow loading and dumping tags with an attribute named "name"
@javiereguiluz
Copy link
Member

Closed as fixed in #18802.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DependencyInjection hasPR A Pull Request has already been submitted for this issue. Keep open
Projects
None yet
Milestone
5.1
5 participants
@fabpot @javiereguiluz @stof @OskarStark @xabbuh