Skip to content

Clarify deprecation handling in the PhpUnitBridge #7312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xabbuh opened this issue Jan 3, 2017 · 0 comments
Closed

Clarify deprecation handling in the PhpUnitBridge #7312

xabbuh opened this issue Jan 3, 2017 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. PHPUnitBridge Status: Needs Review

Comments

@xabbuh
Copy link
Member

xabbuh commented Jan 3, 2017

In https://symfony.com/doc/current/components/phpunit_bridge.html#mark-tests-as-legacy we say that there are four ways to declare a test as legacy:

There are four ways to mark a test as legacy:

  • (Recommended) Add the @group legacy annotation to its class or method;
  • Make its class name start with the Legacy prefix;
  • Make its method name start with testLegacy instead of test;
  • Make its data provider start with provideLegacy or getLegacy.

However, this is not true. Prefix the name of a data provider method with provideLegacy or getLegacy does not influence the error handling of the test method, but is only useful if your data provider actually triggers deprecations.

@xabbuh xabbuh added actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required) PHPUnitBridge labels Jan 3, 2017
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue. PHPUnitBridge Status: Needs Review
Projects
None yet
Development

No branches or pull requests

2 participants