Skip to content

[Process] PhpExecutableFinder now also looks for the PHP_BINARY env var #9003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Jan 8, 2018 · 1 comment
Closed

[Process] PhpExecutableFinder now also looks for the PHP_BINARY env var #9003

javiereguiluz opened this issue Jan 8, 2018 · 1 comment
Labels
hasPR A Pull Request has already been submitted for this issue. Process
Milestone
4.1

Comments

@javiereguiluz
Copy link
Member

We could add some note/tip in the Process component doc.

@nicolas-grekas do you consider this new feature relevant ... or is it something internal? Thanks!

symfony/symfony#25629
@javiereguiluz javiereguiluz added this to the 4.1 milestone Jan 8, 2018
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jan 31, 2018
@javiereguiluz javiereguiluz mentioned this issue Jan 31, 2018
Closed
javiereguiluz added a commit that referenced this issue Feb 5, 2018
@javiereguiluz
minor #9182 Documented the PhpExecutableFinder utility (javiereguiluz)
f5480e5 
This PR was squashed before being merged into the 2.7 branch (closes #9182).

Discussion
----------

Documented the PhpExecutableFinder utility

I was going to document #9003 ... but I think we should not explain that because it's an internal detail and the code can be changed/improved at any time and we cannot keep the docs in sync. However, we could document the PhpExecutableFinder utility if we decide is useful enough.

Commits
-------

cbd6e2b Documented the PhpExecutableFinder utility
@javiereguiluz
Copy link
Member Author

Fixed by #9182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Process
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
1 participant
@javiereguiluz