Add necessary call to Form::isSubmitted and remove boilerplate #10068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since Symfony 4.0 it's required to call `Form::isSubmitted()` before you call `Form::isValid()` - Remove some unnecessary boilerplate code by using automatic parameter conversion and parameter injection of the `EntityManager`
form/form_collections.rst
Outdated
| { | ||
| $entityManager = $this->getDoctrine()->getManager(); |
There was a problem hiding this comment.
Personally I like removing this code ... but to not complicate the example with more concepts (ParamConverters), let's go back to the original code, but improved with the injection of $em that you proposed. Something like this:
public function edit($id, Request $request, EntityManagerInterface $entityManager)
{
if (null === $task = $entityManager->getRepository(Task::class)->find($id)) {
throw $this->createNotFoundException('No task found for id '.$id);
}
// ...
}|
Thanks @keichinger. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 23, 2018
…rplate (keichinger, javiereguiluz) This PR was submitted for the master branch but it was merged into the 4.0 branch instead (closes #10068). Discussion ---------- Add necessary call to Form::isSubmitted and remove boilerplate This code example was the last parts of the docs that wasn't calling `Form::isSubmitted()` as required as of Symfony 4.0. Other than that I've simplified the action a little bit to remove some rather unnecessary noise in an already little more complicated example to ease reading and understanding it. If you want to keep the boilerplate, I'm more than happy to remove it from this PR :) Commits ------- ae265d7 Update form_collections.rst f140342 Minor refactor 6f2c417 Add necessary call to Form::isSubmitted and remove boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code example was the last parts of the docs that wasn't calling
Form::isSubmitted()as required as of Symfony 4.0.Other than that I've simplified the action a little bit to remove some rather unnecessary noise in an already little more complicated example to ease reading and understanding it. If you want to keep the boilerplate, I'm more than happy to remove it from this PR :)