Skip to content

Mentioned how to redirect and maintain the query string #10373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Mentioned how to redirect and maintain the query string #10373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions controller.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ and ``redirect()`` methods::
// redirects to a route with parameters
return $this->redirectToRoute('blog_show', array('slug' => 'my-page'));

// redirects to a route and mantains the original query string parameters
return $this->redirectToRoute('blog_show', $request->query->all());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good! I'm just thinking, would it be worth it having the base controller support the following syntax?

return $this->redirectToRoute('blog_show', $request->query);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it's better to not add a new way to get the query string params. Let's keep things simple and minimize the number of methods/features to learn. Thanks!


// redirects externally
return $this->redirect('http://symfony.com/doc');
}
Expand Down