Skip to content

Added description for the "validation_groups" option #10514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

stollr
Copy link

@stollr stollr commented Oct 18, 2018

As requested in #4401 a description of the "validation_groups" option of the base FormType has been added.

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we also have a dedicated article about this feature. I think we should add a link to it.

@stollr
Copy link
Author

stollr commented Oct 21, 2018

I'll have a look at it when I'm back from holidays ;-)

@nicolas-grekas
Copy link
Member

back? :)

@stollr
Copy link
Author

stollr commented Nov 10, 2018

Yes, but I have not finished all changes. I hope I'll get it done next week ;-)

@stollr stollr force-pushed the form_validation_groups branch from e6a6f9a to 9b6b757 Compare November 13, 2018 15:08
@stollr
Copy link
Author

stollr commented Nov 13, 2018

I have extended the documentation with the hints you gave (@OskarStark and @xabbuh). This was harder than I thould it would be, when I picked the issue ^^ but I hope it contains all needed information, now.

@xabbuh xabbuh added this to the 2.8 milestone Nov 13, 2018
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍🏻

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with some minor comments

naitsirch added 3 commits November 15, 2018 14:50
As requested in symfony#4401 a description of the "validation_groups" option of the base ``FormType`` is added.
@stollr stollr force-pushed the form_validation_groups branch from 9b6b757 to 6185a26 Compare November 15, 2018 13:51
@stollr
Copy link
Author

stollr commented Nov 15, 2018

@OskarStark and @xabbuh thanks for your improvements. I've updated the PR again.

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. Great work!

@xabbuh xabbuh modified the milestones: 2.8, 3.4 Nov 28, 2018
@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2018

Thank you @Naitsirch.

xabbuh added a commit that referenced this pull request Nov 30, 2018
…itsirch)

This PR was submitted for the 2.8 branch but it was squashed and merged into the 3.4 branch instead (closes #10514).

Discussion
----------

Added description for the "validation_groups" option

As requested in #4401 a description of the "validation_groups" option of the base ``FormType`` has been added.

Commits
-------

7d3fe72 Added description for the "validation_groups" option
xabbuh added a commit that referenced this pull request Nov 30, 2018
@xabbuh xabbuh closed this Nov 30, 2018
xabbuh added a commit that referenced this pull request Nov 30, 2018
* 3.4:
  [#10259] minor tweaks
  Unexpected PHP behavior
  [#10514] remove trailing whitespaces
  Added description for the "validation_groups" option
  Tip about using stopwatch to show in profiler page
xabbuh added a commit that referenced this pull request Nov 30, 2018
* 4.1:
  [#10704] fix the line length
  [#10259] minor tweaks
  Unexpected PHP behavior
  [#10514] remove trailing whitespaces
  Added description for the "validation_groups" option
  Don't recommend requiring with Composer
  Tip about using stopwatch to show in profiler page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants