-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added description for the "validation_groups" option #10514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we also have a dedicated article about this feature. I think we should add a link to it.
These are the articles we should probably link to: |
I'll have a look at it when I'm back from holidays ;-) |
back? :) |
Yes, but I have not finished all changes. I hope I'll get it done next week ;-) |
e6a6f9a
to
9b6b757
Compare
I have extended the documentation with the hints you gave (@OskarStark and @xabbuh). This was harder than I thould it would be, when I picked the issue ^^ but I hope it contains all needed information, now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with some minor comments
As requested in symfony#4401 a description of the "validation_groups" option of the base ``FormType`` is added.
…for form option 'validation_groups'
9b6b757
to
6185a26
Compare
@OskarStark and @xabbuh thanks for your improvements. I've updated the PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot. Great work!
Thank you @Naitsirch. |
…itsirch) This PR was submitted for the 2.8 branch but it was squashed and merged into the 3.4 branch instead (closes #10514). Discussion ---------- Added description for the "validation_groups" option As requested in #4401 a description of the "validation_groups" option of the base ``FormType`` has been added. Commits ------- 7d3fe72 Added description for the "validation_groups" option
As requested in #4401 a description of the "validation_groups" option of the base
FormType
has been added.