Skip to content

add $context argument to supportsNormalization() #11994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 19, 2019

reverts #11613, the context will actually be passed as the third argument here (see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Serializer/Serializer.php#L242)

@xabbuh xabbuh added this to the 3.4 milestone Jul 19, 2019
@xabbuh
Copy link
Member Author

xabbuh commented Jul 19, 2019

The feature itself was introduced with symfony/symfony#19371 in Symfony 3.3.

@javiereguiluz
Copy link
Member

Thanks Christian.

@javiereguiluz javiereguiluz merged commit 9a44b3f into symfony:3.4 Jul 19, 2019
javiereguiluz added a commit that referenced this pull request Jul 19, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

add $context argument to supportsNormalization()

reverts #11613, the context will actually be passed as the third argument here (see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Serializer/Serializer.php#L242)

Commits
-------

9a44b3f add $context argument to supportsNormalization()
@xabbuh xabbuh deleted the symfony-30397 branch July 19, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants