[HttpClient] Add buffer configuration option to http_client #12043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR 32565, a regex value was added as a check to automatically buffer the content of a call
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Sep 9, 2019
…th a Closure (rjwebdev) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Allow enabling buffering conditionally with a Closure | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31883 | License | MIT | Doc PR | symfony/symfony-docs#12043 With this PR, responses can be buffered automatically from a closure passed to the `buffer` option. ```php $resp = $client->request('GET', $url, [ 'buffer' => function (array $headers): bool { return true/false; }, ]); ``` When no option is provided, buffering is now enabled only for json, xml and text/* content types. Commits ------- f705ac9 [HttpClient] Allow enabling buffering conditionally with a Closure
symfony-splitter
pushed a commit
to symfony/http-client
that referenced
this pull request
Sep 9, 2019
…th a Closure (rjwebdev) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Allow enabling buffering conditionally with a Closure | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31883 | License | MIT | Doc PR | symfony/symfony-docs#12043 With this PR, responses can be buffered automatically from a closure passed to the `buffer` option. ```php $resp = $client->request('GET', $url, [ 'buffer' => function (array $headers): bool { return true/false; }, ]); ``` When no option is provided, buffering is now enabled only for json, xml and text/* content types. Commits ------- f705ac9dc4 [HttpClient] Allow enabling buffering conditionally with a Closure
OskarStark
approved these changes
Sep 9, 2019
| **type**: ``bool`` | ``string`` | ||
|
|
||
| Option that allows to buffer the content of the response and access it multiple times without performing the request again. | ||
| If boolean value given, request will be buffered or not according to the boolean value. If a string is given, this should |
There was a problem hiding this comment.
Suggested change
| If boolean value given, request will be buffered or not according to the boolean value. If a string is given, this should | |
| If a boolean value is given, the request will be buffered or not according to the boolean value. If a string is given, this should |
|
|
||
| Option that allows to buffer the content of the response and access it multiple times without performing the request again. | ||
| If boolean value given, request will be buffered or not according to the boolean value. If a string is given, this should | ||
| be a regex matching the response content-types that |
There was a problem hiding this comment.
Suggested change
| be a regex matching the response content-types that | |
| be a regex matching the response content-types that should be buffered. |
| Option that allows to buffer the content of the response and access it multiple times without performing the request again. | ||
| If boolean value given, request will be buffered or not according to the boolean value. If a string is given, this should | ||
| be a regex matching the response content-types that | ||
| should be buffered |
There was a problem hiding this comment.
Suggested change
| should be buffered |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Sep 18, 2019
…ttp_client (rjwebdev) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Add buffer configuration option to http_client In PR symfony/symfony#32565, a regex value was added as a check to automatically buffer the content of a call. Since this is a new feature, the documentation of the http_client configuration true frameworkbundle is updated <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 0f65736 Add buffer configuration option to http_client
|
@rjwebdev thanks for this ... and congrats on your first Symfony Docs contribution! @OskarStark I did some rewords while merging. Thanks. |
sadafrangian3
pushed a commit
to sadafrangian3/Dependency-Injection-http-client
that referenced
this pull request
Nov 2, 2022
…th a Closure (rjwebdev) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Allow enabling buffering conditionally with a Closure | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31883 | License | MIT | Doc PR | symfony/symfony-docs#12043 With this PR, responses can be buffered automatically from a closure passed to the `buffer` option. ```php $resp = $client->request('GET', $url, [ 'buffer' => function (array $headers): bool { return true/false; }, ]); ``` When no option is provided, buffering is now enabled only for json, xml and text/* content types. Commits ------- f705ac9dc4 [HttpClient] Allow enabling buffering conditionally with a Closure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR symfony/symfony#32565, a regex value was added as a check to automatically buffer the content of a call. Since this is a new feature, the documentation of the http_client configuration true frameworkbundle is updated