Skip to content

[HttpClient] Add buffer configuration option to http_client #12043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019
Merged

[HttpClient] Add buffer configuration option to http_client #12043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add buffer configuration option to http_client 
In PR 32565, a regex value was added as a check to automatically buffer the content of a call
  • Loading branch information
@rjwebdev
rjwebdev authored Jul 26, 2019
commit 0f65736fb25018288c5ca09396be2beef874e75e
12 changes: 12 additions & 0 deletions reference/configuration/framework.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ Configuration
* :ref:`default_options <reference-http-client-default-options>`

* `bindto`_
* `buffer`_
* `cafile`_
* `capath`_
* `ciphers`_
Expand All @@ -118,6 +119,7 @@ Configuration
* `auth_bearer`_
* `base_uri`_
* `bindto`_
* `buffer`_
* `cafile`_
* `capath`_
* `ciphers`_
Expand Down Expand Up @@ -779,6 +781,16 @@ bindto
A network interface name, IP address, a host name or a UNIX socket to use as the
outgoing network interface.

buffer
......

**type**: ``bool`` | ``string``

Option that allows to buffer the content of the response and access it multiple times without performing the request again.
If boolean value given, request will be buffered or not according to the boolean value. If a string is given, this should
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If boolean value given, request will be buffered or not according to the boolean value. If a string is given, this should
If a boolean value is given, the request will be buffered or not according to the boolean value. If a string is given, this should

be a regex matching the response content-types that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
be a regex matching the response content-types that
be a regex matching the response content-types that should be buffered.

should be buffered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
should be buffered


cafile
......

Expand Down